Oved Ourfali has posted comments on this change. Change subject: core: importing external and hosted-engine VMs to the engine ......................................................................
Patch Set 6: Eli - I saw that in the current commands, the canDoAction doesn't always call the super canDoAction. If that's a bug, then I agree we can use one canDoAction in VmCommand, and use a map (like today) or annotations to denote whether a command can be run on external VMs or not. If, however, it isn't a bug, then it should be in the command itself. -- To view, visit http://gerrit.ovirt.org/17269 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b933df39aaf6897a675aef0564d3fb4922f12e7 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
