Alon Bar-Lev has posted comments on this change. Change subject: packaging: services: ovirt-engine: dump memory on OutOfMemoryError is now default ......................................................................
Patch Set 9: (1 comment) .................................................... File packaging/sys-etc/logrotate.d/ovirt-engine.in Line 15: rotate 1 Line 16: } Line 17: Line 18: "@ENGINE_LOG@/dump"/*.hprof { Line 19: monthly Well, if this happens, you lose the pid... I expected implementation of a template with @PID@ (at least) replaced... you cannot know what pid is when executing the program to specify it as parameter :) Nevermind let's keep it as-is. Line 20: missingok Line 21: compress Line 22: nocreate Line 23: rotate 1 -- To view, visit http://gerrit.ovirt.org/17466 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2690bd371847561717a38410b4431f5e0edb185 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <liran.zel...@gmail.com> Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liran Zelkha <liran.zel...@gmail.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches