Gilad Chaplik has uploaded a new change for review. Change subject: webadmin: fix cpu-pinning info icon message ......................................................................
webadmin: fix cpu-pinning info icon message Width and extra line. Change-Id: I5f4187c27f375911ada646c6f3d7ee59ec2dbeeb Signed-off-by: Gilad Chaplik <gchap...@redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java 2 files changed, 7 insertions(+), 7 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/65/17765/1 diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java index da91afc..2f48dd5 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java @@ -1,7 +1,6 @@ package org.ovirt.engine.ui.common; import com.google.gwt.i18n.client.Constants; -import com.google.gwt.i18n.client.Constants.DefaultStringValue; public interface CommonApplicationConstants extends Constants { @@ -1230,9 +1229,10 @@ String cpuPinningLabel(); @DefaultStringValue("Format: v#p[_v#p]\n" + - "Examples:0#0 => pin vCPU 0 to pCPU 0\n" + - " 0#0_1#3 => pin vCPU 0 to pCPU 0 and pin vCPU 1 to pCPU 3\n" + - " 1#1-4,^2 => pin vCPU 1 to pCPU set 1 to 4, excluding 2") + "Examples:\n" + + "0#0 => pin vCPU 0 to pCPU 0\n" + + "0#0_1#3 => pin vCPU 0 to pCPU 0 and pin vCPU 1 to pCPU 3\n" + + "1#1-4,^2 => pin vCPU 1 to pCPU set 1 to 4, excluding 2") String cpuPinningLabelExplanation(); @DefaultStringValue("Migration is NOT currently supported using SPICE Native USB redirection on cluster version lower than 3.2") diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java index 40486b3..1afb830 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java @@ -1,5 +1,7 @@ package org.ovirt.engine.ui.common.widget.uicommon.popup; +import static org.ovirt.engine.ui.common.widget.uicommon.popup.vm.PopupWidgetConfig.simpleField; + import java.util.ArrayList; import java.util.Arrays; import java.util.List; @@ -76,8 +78,6 @@ import com.google.gwt.user.client.ui.RadioButton; import com.google.gwt.user.client.ui.ValueLabel; import com.google.gwt.user.client.ui.Widget; - -import static org.ovirt.engine.ui.common.widget.uicommon.popup.vm.PopupWidgetConfig.simpleField; public abstract class AbstractVmPopupWidget extends AbstractModeSwitchingPopupWidget<UnitVmModel> { @@ -610,7 +610,7 @@ copyTemplatePermissionsEditor = new EntityModelCheckBoxEditor(Align.RIGHT, new ModeSwitchingVisibilityRenderer()); isMemoryBalloonDeviceEnabled = new EntityModelCheckBoxEditor(Align.RIGHT); isSingleQxlEnabledEditor = new EntityModelCheckBoxEditor(Align.RIGHT, new ModeSwitchingVisibilityRenderer()); - cpuPinningInfo = new InfoIcon(applicationTemplates.italicFixedWidth("465px", //$NON-NLS-1$ + cpuPinningInfo = new InfoIcon(applicationTemplates.italicFixedWidth("400px", //$NON-NLS-1$ constants.cpuPinningLabelExplanation()), resources); priorityEditor = new EntityModelCellTable<ListModel>( -- To view, visit http://gerrit.ovirt.org/17765 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5f4187c27f375911ada646c6f3d7ee59ec2dbeeb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches