Yair Zaslavsky has posted comments on this change.
Change subject: core: remove cleared tasks from _listTasks
......................................................................
Patch Set 1:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandMultiAsyncTasks.java
Line 132:
Line 133: for (CommandAsyncTask task : CurrentActionTypeTasks) {
Line 134: if (task.getLastTaskStatus().getStatus() ==
AsyncTaskStatusEnum.finished) {
Line 135: task.clearAsyncTask();
Line 136: if (task.getVdsmTaskId() != null) {
I agree with Allon's comment - please also notice that task.clearAsyncTask does
not return a value you can check and decide whether to act accordingly.
Line 137: _listTasks.remove(task.getVdsmTaskId());
Line 138: }
Line 139: }
Line 140: }
--
To view, visit http://gerrit.ovirt.org/17733
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibbbafbb9516c731c263ec1a5ac055705022829cf
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
