Roy Golan has posted comments on this change.

Change subject: core, rest, frontend: fix re-initialization flow
......................................................................


Patch Set 3:

(1 comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
Line 626:                             InitializationType.Sysprep :
Line 627:                             InitializationType.CloudInit);
Line 628:                 }
Line 629:             } else {
Line 630:                 
getVm().setInitializationType(getParameters().getInitializationType());
why do we update this in the vm object?
Line 631:             }
Line 632: 
Line 633:             // if we attach floppy we don't need the sysprep
Line 634:             if (!StringUtils.isEmpty(getVm().getFloppyPath())) {


-- 
To view, visit http://gerrit.ovirt.org/17626
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2ff258809c7fedcb7336f4e37be9bc53f2678824
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Ori Liel <ol...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to