Yair Zaslavsky has posted comments on this change.
Change subject: engine : User who can't manipulate users, can add user if he
has manipulate_permission action group.
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Just fix the comment.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddPermissionCommand.java
Line 148: permission.getObjectType(),
Line 149: getActionType().getActionGroup()));
Line 150: initUserAndGroupData();
Line 151: // if the user does not exist in the database we need to
Line 152: // check if the user has permissions to add a user
A bit confusing comment.
I would rephrase -
"check if the logged in ser has permissions to add another user from the
directory service"
Line 153: if (getParameters().getVdcUser() != null && _dbUser == null) {
Line 154: permissionsSubject.add(new
PermissionSubject(MultiLevelAdministrationHandler.SYSTEM_OBJECT_ID,
Line 155: VdcObjectType.System,
Line 156: VdcActionType.AddUser.getActionGroup()));
--
To view, visit http://gerrit.ovirt.org/17593
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib62e1c051bc78b8a9ec0f32e6ba4eb9484242591
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
