ofri masad has uploaded a new change for review. Change subject: core: Fix CPU shares in VmInfoBuilder ......................................................................
core: Fix CPU shares in VmInfoBuilder When CPU shares are 0, the info builder should not include the cpuShares node in the info (so that in vdsm the CPU shares capability will just be disabled) Change-Id: I45e75b2c91049f5e7e74e208adcdcf0ee7c3a8d6 Signed-off-by: Ofri Masad <oma...@redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/17/17717/1 diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java index 35e97ad..148b765 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java @@ -92,8 +92,10 @@ } createInfo.put(VdsProperties.niceLevel, String.valueOf(vm.getNiceLevel())); - createInfo.put(VdsProperties.cpuShares, - String.valueOf(vm.getCpuShares())); + if (vm.getCpuShares() > 0) { + createInfo.put(VdsProperties.cpuShares, + String.valueOf(vm.getCpuShares())); + } if (!StringUtils.isEmpty(vm.getHibernationVolHandle())) { createInfo.put(VdsProperties.hiberVolHandle, vm.getHibernationVolHandle()); -- To view, visit http://gerrit.ovirt.org/17717 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I45e75b2c91049f5e7e74e208adcdcf0ee7c3a8d6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <oma...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches