Alissa Bonas has posted comments on this change.

Change subject: restapi: allow storage conn deletion with no host
......................................................................


Patch Set 1:

(3 comments)

....................................................
Commit Message
Line 13: This change allows deleting the connection from db without the need to
Line 14: disconnect the host from it, since the connection could have been
Line 15: created without connecting the host to it.
Line 16: The option to delete connection and disconnect it via the host remains
Line 17: supported as well.
no, but I will add the feature page.
Line 18: 
Line 19: Change-Id: I7cd9dcea95028e12872beb2496c4338654cfbdb4


....................................................
File 
backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/StorageServerConnectionsResource.java
Line 31:     @Consumes({ ApiMediaType.APPLICATION_XML, 
ApiMediaType.APPLICATION_JSON, ApiMediaType.APPLICATION_X_YAML })
Line 32:     public Response add(StorageConnection storageConnection);
Line 33: 
Line 34:     /**
Line 35:      * Deletes the connection from db, and disconnects the specified 
host from it
ok will change
Line 36:      * @param id
Line 37:      * @param host
Line 38:      * @return
Line 39:      */


Line 42:     @Path("{id}")
Line 43:     public Response remove(@PathParam("id") String id, Host host);
Line 44: 
Line 45:     /**
Line 46:      * Deletes the connection from db
ok will change
Line 47:      * @param id
Line 48:      * @return
Line 49:      */
Line 50:     @DELETE


-- 
To view, visit http://gerrit.ovirt.org/17568
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7cd9dcea95028e12872beb2496c4338654cfbdb4
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to