Moti Asayag has posted comments on this change. Change subject: restapi: Add vnicprofile to vm/template nics ......................................................................
Patch Set 5: (6 comments) .................................................... Commit Message Line 14: as deprecated. Line 15: Line 16: The engine will handle requests which use the network name and Line 17: port mirroring till these properties will be removed from the Line 18: api. Done Line 19: Line 20: Change-Id: I6f60bd2412aebf40c7dc1bf32fdae350b095f60e .................................................... File backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd Line 2718: <xs:element name="active" type="xs:boolean" minOccurs="0"/> <!-- Deprecated, replaced by 'plugged' --> Line 2719: <xs:element name="plugged" type="xs:boolean" minOccurs="0"/> Line 2720: <xs:element ref="port_mirroring" minOccurs="0" maxOccurs="1"/> <!-- Deprecated, replaced by 'vnic_profile' --> Line 2721: <xs:element ref="reported_devices" minOccurs="0" maxOccurs="1"/> Line 2722: <xs:element ref="vnic_profile" minOccurs="0" maxOccurs="1"/> I don't mind squashing them altogether but the patches were introduced in a certain order which add first the vnic profile, followed by extending the network with new parameter and now this patch. I'll squash this patch into the first one, and we'll have to continue discussion over there, since this patch will be abandoned. specifically, vnic profiles was introduced here: http://gerrit.ovirt.org/#/c/17587/ Line 2723: </xs:sequence> Line 2724: </xs:extension> Line 2725: </xs:complexContent> Line 2726: </xs:complexType> .................................................... File backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml Line 530: nic.mac.address: 'xs:string' Line 531: nic.interface: 'xs:string' Line 532: nic.port_mirroring.networks.network--COLLECTION: {network.id: 'xs:string'} #deprecated, replaced by vnicprofile.id Line 533: nic.plugged: 'xs:boolean' Line 534: nic.vnic_profile.id: 'xs:string' Done Line 535: urlparams: {} Line 536: headers: Line 537: Content-Type: {value: application/xml|json, required: true} Line 538: Correlation-Id: {value: 'any string', required: false} Line 566: nic.mac.address: 'xs:string' Line 567: nic.interface: 'xs:string' Line 568: nic.port_mirroring.networks.network--COLLECTION: {network.id: 'xs:string'} #deprecated, replaced by vnicprofile.id Line 569: nic.plugged: 'xs:boolean' Line 570: nic.vnic_profile.id: 'xs:string' Done Line 571: urlparams: {} Line 572: headers: Line 573: Content-Type: {value: application/xml|json, required: true} Line 574: Expect: {value: 201-created, required: false} Line 2774: nic.linked: 'xs:boolean' Line 2775: nic.mac.address: 'xs:string' Line 2776: nic.interface: 'xs:string' Line 2777: nic.port_mirroring.networks.network--COLLECTION: {network.id: 'xs:string'} #deprecated, replaced by vnicprofile.id Line 2778: nic.vnic_profile.id: 'xs:string' Done Line 2779: urlparams: {} Line 2780: headers: Line 2781: Content-Type: {value: application/xml|json, required: true} Line 2782: Expect: {value: 201-created, required: false} Line 2809: nic.name: 'xs:string' Line 2810: nic.mac.address: 'xs:string' Line 2811: nic.interface: 'xs:string' Line 2812: nic.port_mirroring.networks.network--COLLECTION: {network.id: 'xs:string'} #deprecated, replaced by vnicprofile.id Line 2813: nic.vnic_profile.id: 'xs:string' Done Line 2814: urlparams: {} Line 2815: headers: Line 2816: Content-Type: {value: application/xml|json, required: true} Line 2817: Correlation-Id: {value: 'any string', required: false} -- To view, visit http://gerrit.ovirt.org/17611 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6f60bd2412aebf40c7dc1bf32fdae350b095f60e Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
