Daniel Erez has posted comments on this change.
Change subject: webadmin: add VnicProfile as main tab
......................................................................
Patch Set 31: Code-Review+2
(4 comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/VnicProfileListModel.java
Line 65: return;
Line 66: }
Line 67:
Line 68: // TODO - fix
Line 69: // final VnicProfileModel profileModel = new
NewVnicProfileModel(this, getEntity().getCompatibilityVersion());
is it pending on 'CompatibilityVersion' attribute in VnicProfile?
Line 70: final VnicProfileModel profileModel = new
NewVnicProfileModel(this, Version.v3_3);
Line 71: setWindow(profileModel);
Line 72:
Line 73: initNetworkList(profileModel);
Line 181: protected void syncSearch() {
Line 182: // TODO - fix
Line 183: // SearchParameters tempVar = new
SearchParameters(getSearchString(), SearchType.Profile);
Line 184: // tempVar.setMaxCount(getSearchPageSize());
Line 185: // super.syncSearch(VdcQueryType.Search, tempVar);
I assume it's pending on search support for profiles?
Line 186:
Line 187: SystemTreeItemModel treeSelectedItem =
Line 188: (SystemTreeItemModel)
CommonModel.getInstance().getSystemTree().getSelectedItem();
Line 189:
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/VnicProfileTemplateListModel.java
Line 46: @Override
Line 47: public void setItems(Iterable value) {
Line 48: if (value != null) {
Line 49: List<VmTemplate> itemList = (List<VmTemplate>) value;
Line 50: Collections.sort(itemList, new Comparator<VmTemplate>() {
please move to Linq
Line 51:
Line 52: @Override
Line 53: public int compare(VmTemplate paramT1,
Line 54: VmTemplate paramT2) {
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/VnicProfileVmListModel.java
Line 45:
Line 46: @Override
Line 47: public void setItems(Iterable value) {
Line 48: if (value != null) {
Line 49: List<VM> itemList = (List<VM>) value;
same
Line 50: Collections.sort(itemList, new Comparator<VM>() {
Line 51:
Line 52: @Override
Line 53: public int compare(VM paramT1,
--
To view, visit http://gerrit.ovirt.org/16998
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ied73fa4ecdb58c3224dc78f6641b2d56d55ec73b
Gerrit-PatchSet: 31
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
