Daniel Erez has posted comments on this change.
Change subject: webadmin: network profiles
......................................................................
Patch Set 31: Code-Review+2
(5 comments)
Please address comments before merging.
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/PermissionListModel.java
Line 373: }
Line 374: if (getEntity() instanceof Network) {
Line 375: return VdcObjectType.Network;
Line 376: }
Line 377: if (getEntity() instanceof VnicProfile){
doesn't it belong to: http://gerrit.ovirt.org/#/c/17571 ?
Line 378: return VdcObjectType.VnicProfile;
Line 379: }
Line 380: return VdcObjectType.Unknown;
Line 381: }
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkProfileListModel.java
Line 25: private UICommand newCommand;
Line 26: private UICommand editCommand;
Line 27: private UICommand removeCommand;
Line 28:
Line 29: private PermissionListModel permissionListModel;
is it needed here?
Line 30:
Line 31: public NetworkProfileListModel() {
Line 32:
setTitle(ConstantsManager.getInstance().getConstants().profilesTitle());
Line 33: setHashName("profiles"); //$NON-NLS-1$
Line 81: }
Line 82:
Line 83: public void edit()
Line 84: {
Line 85: if (getWindow() != null)
please format the entire file with curly brackets at the end of line...
Line 86: {
Line 87: return;
Line 88: }
Line 89:
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/VnicProfileModel.java
Line 209: new AsyncQuery(this,
Line 210: new INewAsyncCallback() {
Line 211: @Override
Line 212: public void onSuccess(Object target,
Object returnValue) {
Line 213: stopProgress();
better move to the end of the method...
Line 214: if (returnValue != null) {
Line 215: Map<String, String>
customPropertiesList =
Line 216: ((Map<String,
String>) ((VdcQueryReturnValue) returnValue).getReturnValue());
Line 217:
....................................................
File
frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
Line 2048: String cloudInitAttachmentTypeBase64();
Line 2049:
Line 2050: @DefaultStringValue("Content must be Base64")
Line 2051: String cloudInitBase64Message();
Line 2052:
tws
Line 2053: @DefaultStringValue("VNIC Profile")
Line 2054: String vnicProfileTitle();
--
To view, visit http://gerrit.ovirt.org/16924
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icedb35f0e9277663a3b4525574c3b0dbbd2086db
Gerrit-PatchSet: 31
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
