Daniel Erez has posted comments on this change. Change subject: userportal : Fix DiskForVmGuid high CPU ......................................................................
Patch Set 6: Verified-1 Code-Review-1 (1 comment) The basic tab displays multiple disks (one for each snapshot). Please filter them by 'active' column... .................................................... File packaging/dbscripts/all_disks_sp.sql Line 62: RETURN QUERY SELECT disk_id,disk_alias, size Line 63: FROM images Line 64: LEFT OUTER JOIN base_disks ON images.image_group_id = base_disks.disk_id Line 65: LEFT JOIN vm_device ON vm_device.device_id = image_group_id AND (NOT v_only_plugged OR is_plugged) Line 66: WHERE vm_device.vm_id = v_vm_guid please add 'AND images.active = true' Line 67: AND (NOT v_is_filtered OR EXISTS (SELECT 1 Line 68: FROM user_disk_permissions_view Line 69: WHERE user_id = v_user_id AND entity_id = disk_id)); Line 70: -- To view, visit http://gerrit.ovirt.org/16657 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iceb6e518936f65403561703e6b70920fbcc1f07c Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <liran.zel...@gmail.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Liran Zelkha <liran.zel...@gmail.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
