Moti Asayag has posted comments on this change. Change subject: engine: Import VM configure the vnic profile ......................................................................
Patch Set 15: (1 comment) I agree the code here isn't optimal, but it was a matter of a 2 patches till i refactored it into a proper method. The logic remains the same but the smell vanished from the code. See http://gerrit.ovirt.org/#/c/17442 (which you've already acked :-) ) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java Line 1094: } Line 1095: Line 1096: iface.setVnicProfileId(vnicProfile.getId()); Line 1097: addVnic(vmInterfaceManager, iface); Line 1098: continue; agreed. i didn't put too much effort on this one since i realized same logic should be reused in another scenario. In a latter patch i've extracted it properly into a method inside VmInterfaceManager for re-usability. Line 1099: } Line 1100: Line 1101: auditInvalidInterfaces(invalidNetworkNames, invalidIfaceNames); Line 1102: } -- To view, visit http://gerrit.ovirt.org/17440 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I890a214e879c740dd1dbdebca25529786231cbd6 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
