Daniel Erez has posted comments on this change.
Change subject: webadmin: adding description to vnic profile dialogs and tables
......................................................................
Patch Set 8: Code-Review+2
(2 comments)
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVnicProfileView.java
Line 53: return object.getDescription();
Line 54: }
Line 55: };
Line 56:
Line 57: getTable().addColumn(descriptionColumn,
constants.descriptionVnicProfile(), "400px"); //$NON-NLS-1$
have you checked it on low resolutions?
Line 58:
Line 59: getTable().addActionButton(new
WebAdminButtonDefinition<VnicProfileView>(constants.newVnicProfile()) {
Line 60: @Override
Line 61: protected UICommand resolveCommand() {
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkProfileView.java
Line 44: public String getValue(VnicProfileView object) {
Line 45: return object.getDescription();
Line 46: }
Line 47: };
Line 48: getTable().addColumn(descriptionColumn,
constants.descriptionVnicProfile(), "400px"); //$NON-NLS-1$
same
Line 49:
Line 50: BooleanColumn<VnicProfileView> portMirroringColumn =
Line 51: new
BooleanColumn<VnicProfileView>(constants.portMirroringEnabled()) {
Line 52: @Override
--
To view, visit http://gerrit.ovirt.org/17572
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I84792a871c7e9dfbb39d4227d7ce82d84be25f1b
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
