Moti Asayag has posted comments on this change.

Change subject: engine: Add query to retrieve all vnic profiles
......................................................................


Patch Set 31:

(1 comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/GetAllVnicProfilesQuery.java
Line 2: 
Line 3: import org.ovirt.engine.core.bll.QueriesCommandBase;
Line 4: import org.ovirt.engine.core.common.queries.IdQueryParameters;
Line 5: 
Line 6: public class GetAllVnicProfilesQuery<P extends IdQueryParameters> 
extends QueriesCommandBase<P> {
already changed it without looking the comment when i saw the client which uses 
it and i wonder why the client provide an empty IdQueryParameters for this 
query...since this query isnt required actual ID.
Also modified the clients which invoke this query to provide 
VdcQueryParametersBase.


in other words: Done!
Line 7:     public GetAllVnicProfilesQuery(P parameters) {
Line 8:         super(parameters);
Line 9:     }
Line 10: 


-- 
To view, visit http://gerrit.ovirt.org/16672
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I811391b99d193b44874c3f2355ef08e0bb6e1cff
Gerrit-PatchSet: 31
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to