Moti Asayag has posted comments on this change.
Change subject: engine: Add SP for retrieving vms by vnic profile
......................................................................
Patch Set 24:
(3 comments)
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAO.java
Line 262: * @param vNicProfileId
Line 263: * the vm network interface profile id
Line 264: * @return the list of VMs
Line 265: */
Line 266: List<VM> getAllForVnicProfile(Guid vNicProfileId);
Done
....................................................
File
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDAOTest.java
Line 413: * Ensures that no vms are fetched since the network is not
assigned to any cluster
Line 414: */
Line 415: @Test
Line 416: public void testGetAllForVnicProfileEmpty() {
Line 417: List<VM> result =
dao.getAllForNetwork(FixturesTool.NETWORK_NO_CLUSTERS_ATTACHED);
will fix.
Line 418: assertNotNull(result);
Line 419: assertTrue(result.isEmpty());
Line 420: }
Line 421:
....................................................
File packaging/dbscripts/vms_sp.sql
Line 1127: WHERE EXISTS (
Line 1128: SELECT 1
Line 1129: FROM vm_interface
Line 1130: INNER JOIN vnic_profiles
Line 1131: ON vnic_profiles.id = vm_interface.vnic_profile_id
Done
Line 1132: WHERE vm_interface.vnic_profile_id = v_vnic_profile_id
Line 1133: AND vm_interface.vm_guid = vms.vm_guid);
Line 1134: END; $procedure$
Line 1135: LANGUAGE plpgsql;
--
To view, visit http://gerrit.ovirt.org/16669
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib474565480e763030a99b429d3054ed2debfcff2
Gerrit-PatchSet: 24
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
