Roy Golan has posted comments on this change.

Change subject: engine: Incorrect VM TimeZone handling
......................................................................


Patch Set 3:

(1 comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
Line 646:                     getClass().getName(),
Line 647:                     getVmId().toString(),
Line 648:                     getVm().getTimeZone());
Line 649:             getVm().getStaticData().setTimeZone(null);
Line 650:             getVmStaticDAO().update(getVm().getStaticData());
if its a runonce then your overriding the setting of the original VM

better do that on update of a VM and here just fix without persisting the  
vmStatic
Line 651:         }
Line 652:     }
Line 653: 
Line 654:     protected boolean getVdsToRunOn() {


-- 
To view, visit http://gerrit.ovirt.org/17524
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd36656bd4f0288e86b1cbd46d702fa68051e28b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbe...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Martin Betak <mbe...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to