Yair Zaslavsky has posted comments on this change. Change subject: core: Inject Config instance to CommandBase ......................................................................
Patch Set 3: Code-Review+1 (1 comment) Nice. I assume you ran unit tests and saw nothing gets broken. I'm writing there as at first I didn't like the fact Config was made singleton, currently (without injection) it makes our mocks more difficult. .................................................... Commit Message Line 5: CommitDate: 2013-08-05 00:23:44 +0300 Line 6: Line 7: core: Inject Config instance to CommandBase Line 8: Line 9: As part of the dependency injection into Commands class it is now s/Commands class/command classes. Line 10: available at CommandBase. Line 11: Line 12: The Config class was made a singleton so it could be fetched by the CDI Line 13: container. -- To view, visit http://gerrit.ovirt.org/17613 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I42517ed27b29bc91ffe5062ada651a1d5eb07bed Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
