Lior Vernia has uploaded a new change for review.
Change subject: webadmin: Removed unneeded code from HorizontalSplitTable
......................................................................
webadmin: Removed unneeded code from HorizontalSplitTable
When coding it I wasn't aware I could do without it.
Change-Id: I7febc428bfa68b98b73032b2b32b08d1b53d3db6
Signed-off-by: Lior Vernia <lver...@redhat.com>
---
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/HorizontalSplitTable.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/HorizontalSplitTable.ui.xml
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ImportNetworksPopupView.java
3 files changed, 4 insertions(+), 8 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/36/17636/1
diff --git
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/HorizontalSplitTable.java
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/HorizontalSplitTable.java
index d5118ca..244bf8c 100644
---
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/HorizontalSplitTable.java
+++
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/HorizontalSplitTable.java
@@ -17,7 +17,6 @@
import com.google.gwt.core.client.GWT;
import com.google.gwt.event.dom.client.ClickEvent;
import com.google.gwt.event.dom.client.ClickHandler;
-import com.google.gwt.resources.client.CssResource;
import com.google.gwt.uibinder.client.UiBinder;
import com.google.gwt.uibinder.client.UiField;
import com.google.gwt.user.client.ui.ButtonBase;
@@ -34,8 +33,7 @@
WidgetUiBinder uiBinder = GWT.create(WidgetUiBinder.class);
}
- interface Style extends CssResource {
- }
+ private static CommonApplicationConstants constants =
GWT.create(CommonApplicationConstants.class);
private final MultiSelectionModel<EntityModel> topSelectionModel;
private final MultiSelectionModel<EntityModel> bottomSelectionModel;
@@ -68,8 +66,7 @@
public HorizontalSplitTable(EntityModelCellTable<ListModel> topTable,
EntityModelCellTable<ListModel> bottomTable,
String topTitle,
- String bottomTitle,
- CommonApplicationConstants constants) {
+ String bottomTitle) {
this.topTable = topTable;
this.bottomTable = bottomTable;
diff --git
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/HorizontalSplitTable.ui.xml
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/HorizontalSplitTable.ui.xml
index ac2fcb6..21b675a 100644
---
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/HorizontalSplitTable.ui.xml
+++
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/HorizontalSplitTable.ui.xml
@@ -4,7 +4,7 @@
xmlns:g="urn:import:com.google.gwt.user.client.ui"
xmlns:e="urn:import:org.ovirt.engine.ui.common.widget.editor"
xmlns:d="urn:import:org.ovirt.engine.ui.common.widget.dialog">
- <ui:style
type="org.ovirt.engine.ui.common.widget.HorizontalSplitTable.Style">
+ <ui:style>
.headers {
font-weight: bold;
}
diff --git
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ImportNetworksPopupView.java
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ImportNetworksPopupView.java
index ffa104f..994dd71 100644
---
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ImportNetworksPopupView.java
+++
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ImportNetworksPopupView.java
@@ -90,8 +90,7 @@
new HorizontalSplitTable(providerNetworks,
importedNetworks,
constants.providerNetworks(),
- constants.importedNetworks(),
- constants);
+ constants.importedNetworks());
initWidget(ViewUiBinder.uiBinder.createAndBindUi(this));
initEntityModelCellTables(constants, templates, resources);
providersEditor.setLabel(constants.networkProvider());
--
To view, visit http://gerrit.ovirt.org/17636
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7febc428bfa68b98b73032b2b32b08d1b53d3db6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lver...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
