Mike Kolesnik has posted comments on this change.
Change subject: engine Use VmNic within ChangeVMClusterCommand
......................................................................
Patch Set 21: -Code-Review
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVMClusterCommand.java
Line 164: if (iface.getVnicProfileId() != null) {
Line 165: Network net = LinqUtils.firstOrNull(networks, new
Predicate<Network>() {
Line 166: @Override
Line 167: public boolean eval(Network n) {
Line 168: Network network =
NetworkHelper.getNetworkByVnicProfileId(iface.getVnicProfileId());
Please note it would be more efficient to fetch this value before the "linq"
loop
Line 169: return ObjectUtils.equals(n.getId(),
network.getId());
Line 170: }
Line 171: });
Line 172:
--
To view, visit http://gerrit.ovirt.org/17271
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I864201b27d1572bf73a40d692ef3bb503a0f36ca
Gerrit-PatchSet: 21
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
