Yair Zaslavsky has posted comments on this change.
Change subject: WIP: working CDI solution for backend
......................................................................
Patch Set 6: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
Line 98: private DateTime _startedAt;
Line 99: private static boolean firstInitialization = true;
Line 100: private String poolMonitoringJobId;
Line 101:
Line 102: public Backend() {
Why do we needd this empty CTOR in public?
Line 103: }
Line 104:
Line 105: public static BackendInternal getInstance() {
Line 106: return EjbUtils.findBean(BeanType.BACKEND,
BeanProxyType.LOCAL);
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 131:
Line 132: protected Log log = LogFactory.getLog(getClass());
Line 133:
Line 134: @Inject
Line 135: protected DbFacade dbFacade;
Awesome , the next step will be to improve the bll producer class and let it
produce DAOs, so we can inject DAOs directly.
Line 136:
Line 137: /** The context defines how to monitor the command and handle its
compensation */
Line 138: private final CommandContext context = new CommandContext();
Line 139:
--
To view, visit http://gerrit.ovirt.org/5575
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f604ff91847b698efe84a09f724ba0492a672c1
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Asaf Shakarchi <a...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
