Alon Bar-Lev has posted comments on this change.
Change subject: ovirt-live: migrate ovirt live plugin to otopi
......................................................................
Patch Set 2: (3 inline comments)
....................................................
File fedora/kickstart/ovirt.ks
Line 141: sed -i 's/\#WDMDOPTS/WDMDOPTS/g' /etc/sysconfig/wdmd
Line 142: yum localinstall -y /home/oVirtuser/oVirtLiveFiles/rpms/*.rpm
Line 143:
Line 144: # Updating patched files
Line 145: cp -r /home/oVirtuser/root/* /
can you please address?
Line 146:
Line 147:
Line 148: # Manipulate fqdn validation, so that it is possible to setup with
answer file
Line 149: sed -i 's/raise Exception(output_messages.ERR_EXP_VALIDATE_PARAM %
param.getKey("CONF_NAME"))/logging.debug("Failed to validate %s with value
%s",param,paramValue)/g' /usr/share/ovirt-engine/scripts/engine-setup.py
....................................................
File
fedora/oVirtLiveFiles/root/usr/share/ovirt-engine/setup/plugins/ovirt-engine-setup/olive/core.py
Line 173: # Create NIC
Line 174:
engine_api.vms.get('local_vm').nics.add(params.NIC(name='eth0',
network=params.Network(name='ovirtmgmt'), interface='virtio'))
Line 175:
Line 176: sd = engine_api.storagedomains.get('local_storage')
Line 177: diskParam =
params.Disk(storage_domains=params.StorageDomains(storage_domain=[sd]),
not good, single indent:
xxxx = yyy(
aaa=bbb,
cccc=ddd,
)
xxxx = yyyyyyyyyyyyyy(
aaa=bbb,
cccc=ddd,
)
Notice it is always consistent, single indent, no mater how long is yyyy.
closing bracket is at same column as start of statement.
Line 178: size='6000MB',
Line 179: type_='data',
Line 180: interface='virtio',
Line 181: format='cow',
....................................................
File
fedora/oVirtLiveFiles/root/usr/share/ovirt-engine/setup/plugins/ovirt-engine-setup/olive/__init__.py
Line 28:
Line 29: @util.export
Line 30: def createPlugins(context):
Line 31: core.Plugin(context=context)
Line 32:
two spaces here as well
--
To view, visit http://gerrit.ovirt.org/17518
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I703f64dc1183a6fe176d9d0352f93de381d906bb
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-live
Gerrit-Branch: master
Gerrit-Owner: Ohad Basan <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: David Caro <[email protected]>
Gerrit-Reviewer: Eyal Edri <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Ohad Basan <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
