Alon Bar-Lev has posted comments on this change.

Change subject: packaging: add vdsm stage
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File packaging/setup/plugins/ovirt-engine-setup/all-in-one/vdsm.py
Line 170:         stage=plugin.Stages.STAGE_CLOSEUP,
Line 171:         condition=lambda self: self.environment[
Line 172:             osetupcons.AIOEnv.CONFIGURE
Line 173:         ],
Line 174:         name=osetupcons.Stages.AIO_CONFIG_VDSM,
name should be after stage please.
Line 175:         after=(
Line 176:             osetupcons.Stages.AIO_CONFIG_ROOT_PASSWORD,
Line 177:             osetupcons.Stages.AIO_CONFIG_STORAGE,
Line 178:             osetupcons.Stages.CORE_ENGINE_START,


-- 
To view, visit http://gerrit.ovirt.org/17525
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I03b42e98a3d31b76899837e875de8e3d6dc68774
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ohad Basan <oba...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Eyal Edri <ee...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to