Alon Bar-Lev has posted comments on this change.
Change subject: pki: Add a script to extract parts from a PKCS#12
......................................................................
Patch Set 10: (1 inline comment)
....................................................
File packaging/bin/pki-pkcs12-extract.sh
Line 8:
Line 9: local pkcs12="${PKIDIR}/keys/${name}.p12"
Line 10: common_backup "${key}"
Line 11:
Line 12: extra_args="-nodes"
should be:
local extra_args
[ -z "${passout}" ] && extra_args="-nodes"
1. assume nothing
2. always use local
Line 13: [ -n "${passout}" ] && extra_args=""
Line 14:
Line 15: if [ "${key}" = - ]; then
Line 16: key=/dev/fd/1
--
To view, visit http://gerrit.ovirt.org/17562
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica596fe3ef4e5f0a60ae99b0934b10433b9d5023
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
