Mike Kolesnik has posted comments on this change.
Change subject: engine: Prevent modifying port mirroring if used by vms
......................................................................
Patch Set 18: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VnicProfileValidator.java
Line 93: if (vnicProfile.isPortMirroring() ==
getOldVnicProfile().isPortMirroring()) {
Line 94: return ValidationResult.VALID;
Line 95: }
Line 96:
Line 97: return vnicProfileNotUsedByVms();
I think this should be only valid if the VMs are not Down, as per the commit
comment you're worried about discrepancy between active and not active VMs but
if all the VMs with the profile are Down I'm not sure this should be blocked..
Line 98: }
Line 99:
Line 100: protected Network getNetwork() {
Line 101: if (network == null) {
--
To view, visit http://gerrit.ovirt.org/17111
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe7b2c4e4ab133f6d6928d1d18a458103e017baa
Gerrit-PatchSet: 18
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
