Giuseppe Vallarelli has posted comments on this change. Change subject: engine: Update the vnic profile resolution of ImportVmTempalte ......................................................................
Patch Set 7: Looks good to me, but someone else must approve (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java Line 399: nic.setVmTemplateId(getVmTemplateId()); Line 400: nic.setName(iface.getName()); Line 401: nic.setLinked(iface.isLinked()); Line 402: nic.setSpeed(iface.getSpeed()); Line 403: nic.setType(iface.getType()); OK, in that case looks good to me. Line 404: Line 405: if (!vmInterfaceManager.updateNicWithVnicProfile(iface, Line 406: iface.getNetworkName(), Line 407: iface.getVnicProfileName(), -- To view, visit http://gerrit.ovirt.org/17444 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I59004e5c61d2fc98c6d6e26fdb16dc0c469acaf4 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Giuseppe Vallarelli <gvall...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
