Yedidyah Bar David has posted comments on this change.
Change subject: pki: Add a script to extract parts of a PKCS#12 store
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File packaging/bin/pki-pkcs12-extract.sh
Line 1: #!/bin/sh
Alon, you did not reply to all my questions, so I still do not know what you
want.
pki-pkcs12-extract.sh
--name=NAME
--passin=PASS
--passout=PASS
--key=PATH
--cert=PATH
?
Which are optional? If e.g. --key is not provided, or we generate it in a
"default" location? And with which suffix?
You also did not reply about the certificate that's already created. Note that
this will cause a real bug - common_backup will create two backups to the same
destination, meaning in reality there will be no backup (the second one will be
of a now-created file).
nopass is something I never saw, it's private for us. key files that I saw are
always named something.key and that's it. The name does not indicate if it's
encrypted or not - for apache it's not (in all servers I saw so far - although
we did discuss this point a few weeks ago).
Line 2:
Line 3: extractkey() {
Line 4: local name="$1"
Line 5: local pass="$2"
--
To view, visit http://gerrit.ovirt.org/17562
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica596fe3ef4e5f0a60ae99b0934b10433b9d5023
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
