Vitor de Lima has posted comments on this change.

Change subject: core: Create virtio-scsi controller when needed
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File 
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java
Line 230:     }
Line 231: 
Line 232:     @Override
Line 233:     protected void buildVmDrives() {
Line 234:         boolean containsVirtioScsiDisk = false;
Virtio_SCSI is supported, but it causes problems with the SPAPR SCSI interface 
(which is another SCSI controller that PPC guests supports). I think I can work 
around it by creating both interfaces and attaching the disks to the right one 
according to their type.
Line 235:         List<Disk> disks = getSortedDisks();
Line 236:         for (Disk disk : disks) {
Line 237:             Map<String, Object> struct = new HashMap<String, 
Object>();
Line 238:             // get vm device for this disk from DB


-- 
To view, visit http://gerrit.ovirt.org/17526
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife8978c117a6b33a7fb71a3633843f5926b502b8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Vitor de Lima <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to