Yair Zaslavsky has posted comments on this change.
Change subject: core: QueryData2 generates slow SQL for...
......................................................................
Patch Set 2: Looks good to me, approved
(1 inline comment)
Eli,
This is a minor comment, I don't mind approving without it.
....................................................
File
backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java
Line 909: // audit_log_id, this is done to make search queries from
the client more efficient and eliminate the client
Line 910: // from registering to such queries and comparing last
data with previous.
Line 911: String inQuery = "";
Line 912: if (primeryKey.equals("audit_log_id")) {
Line 913: if (wherePhrase.toString().equals("")) {
I would consider using wherePhrase.length() == 0
toString allocates a new String, no reason to do that here.
Line 914: inQuery = StringFormat
Line 915: .format("SELECT * FROM %1$s WHERE ( %2$s
> %3$s and not deleted",
Line 916: tableNameWithOutTags, primeryKey,
Line 917: syntax.getSearchFrom());
--
To view, visit http://gerrit.ovirt.org/17527
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id148adcc734c5742548c74ea754fb70252155e34
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Liran Zelkha <liran.zel...@gmail.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
