Michael Pasternak has posted comments on this change. Change subject: restapi: use storageconnection instead of storage ......................................................................
Patch Set 1: (1 inline comment) .................................................... File backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd Line 1992: </xs:extension> Line 1993: </xs:complexContent> Line 1994: </xs:complexType> Line 1995: Line 1996: <xs:element name="storageconnection" type="StorageConnection"/> naming convention in api is x_y (as you did in "storage_connections"), should be "storage_connection" Line 1997: Line 1998: <xs:complexType name="StorageConnection"> Line 1999: <xs:complexContent> Line 2000: <xs:extension base="BaseResource"> -- To view, visit http://gerrit.ovirt.org/17565 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb401cef8e08e62c57c0ef8afd4677c764d065a9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches