[Engine-patches] Change in ovirt-engine[master]: core: Fix UpdateNetworkQoSCommand canDoAction

[omasad]

ofri masad has uploaded a new change for review.

Change subject: core: Fix UpdateNetworkQoSCommand canDoAction
......................................................................

core: Fix UpdateNetworkQoSCommand canDoAction

the canDoAction was changed to verify 'Peak' value is not set lower than
'Average' value.

Change-Id: Iecd333f8287108373b6bd5e72ac86c3164e85227
Signed-off-by: Ofri Masad <oma...@redhat.com>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/qos/UpdateNetworkQoSCommand.java
1 file changed, 6 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/56/17556/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/qos/UpdateNetworkQoSCommand.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/qos/UpdateNetworkQoSCommand.java
index 958de05..3983d23 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/qos/UpdateNetworkQoSCommand.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/qos/UpdateNetworkQoSCommand.java
@@ -21,8 +21,12 @@
             } else if 
(!oldNetworkQoS.getStoragePoolId().equals(getNetworkQoS().getStoragePoolId())) {
                 return 
failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_NETWORK_QOS_INVALID_DC_ID);
             } else {
-                if (validateValues() && 
!oldNetworkQoS.getName().equals(getNetworkQoS().getName())) {
-                    return validateNameNotExistInDC();
+                if (validateValues()) {
+                    if 
(!oldNetworkQoS.getName().equals(getNetworkQoS().getName())) {
+                        return validateNameNotExistInDC();
+                    }
+                } else {
+                    return false;
                 }
             }
         }


-- 
To view, visit http://gerrit.ovirt.org/17556
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iecd333f8287108373b6bd5e72ac86c3164e85227
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <oma...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches