Yair Zaslavsky has posted comments on this change.
Change subject: core: Fix compareTo for SRV records
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/tools/src/test/java/org/ovirt/engine/core/utils/dns/DnsSRVLocatorTest.java
Line 39: }
Line 40:
Line 41: }
Line 42:
Line 43: @Test
I wanted to demonstrate in this patch how the change at the comparison effects
the test.
Do you think I should squash this patch and the one before it?
Line 44: public void testZeroPriorities() throws Exception {
Line 45: DnsSRVLocator locator = mockLocator("example.com",
Line 46: "10 100 389 a.example.com."
Line 47: , "10 100 389 b.example.com."
--
To view, visit http://gerrit.ovirt.org/17049
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff93a85f529633934515015653c517500bf51c6b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
