Emily Zhang has posted comments on this change. Change subject: engine:Trusted Compute Pools - Open Attestation integration with oVirt engine ......................................................................
Patch Set 7: (1 inline comment) .................................................... File packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql Line 577: select fn_db_add_config_value('PollUri','AttestationService/resources/PollHosts','general'); Line 578: select fn_db_add_config_value('AttestationTruststore','TrustStore.jks','general'); Line 579: select fn_db_add_config_value('AttestationPort','8443','general'); Line 580: select fn_db_add_config_value('AttestationTruststorePass','password','general'); Line 581: select fn_db_add_config_value('AttestationServer','','general'); Eli, is the missing update operation 03_03_0370_add_trusted_service_to_vds_groups.sql located in packaging/dbscripts/upgrade? you can find it in http://gerrit.ovirt.org/#/c/14605 which is merged, and the new patchset is based on it. we have tested those code, and user can set and get these attestation configuration fileds by engine-config utils. if the file is the incorrect one, can you tell us more details information? Line 582: select fn_db_add_config_value('AttestationFirstStageSize','10','general'); Line 583: Line 584: select fn_db_add_config_value('MaxAverageNetworkQoSValue','1024','general'); Line 585: select fn_db_add_config_value('MaxPeakNetworkQoSValue','2048','general'); -- To view, visit http://gerrit.ovirt.org/16987 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I03aba74d09ffe8eb580b369e07232370b3954dec Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gang Wei <gang....@intel.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Dave Chen <wei.d.c...@intel.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Emily Zhang <lijuan.zh...@intel.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-Reviewer: ofri masad <oma...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches