Greg Padgett has posted comments on this change.
Change subject: ovirt-hosted-engine-ha: initial commit
......................................................................
Patch Set 15: (2 inline comments)
2 replies inline. The latest patch set addresses the issues commented upon (I
hope) and also has several fixes for the agent which enable its basic
functionality of providing high availability for the engine vm.
....................................................
File ovirt_hosted_engine_ha/broker/listener.py
Line 44: ConnectionHandler)
Line 45: self._server.timeout = 0.7
Line 46:
Line 47: # Coordinate access to resources across connections
Line 48: self._server.sp_conn_monitors = {}
Good points, thanks. When writing it I had intended for the locks/instance
refs/exit flag to "belong" to the listener and help coordinate access between
its children and its siblig storage broker and monitor classes. Anyhow, to
avoid trying to pass the members/properties with the old-style SocketServer
classes, I sent them to the children via a reference to the listener itself so
that they have an api and object with which with to access them.
Line 49: self._server.sp_conn_monitors_access_lock = threading.Lock()
Line 50: self._server.sp_monitor_instance = monitor_instance
Line 51: self._server.sp_monitor_instance_access_lock = threading.Lock()
Line 52: self._server.sp_storage_broker_instance =
storage_broker_instance
....................................................
File ovirt_hosted_engine_ha/broker/submonitor_base.py
Line 92: threading.Thread(target=self._worker).start()
Line 93:
Line 94: # Wait for status of startup
Line 95: self._initialized.wait()
Line 96: if self._initialization_status is True:
Thanks, I added a comment to the latest patch set about it.
Line 97: return True
Line 98: else:
Line 99: raise Exception(self._initialization_status)
Line 100:
--
To view, visit http://gerrit.ovirt.org/16462
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3853db529ed353e7d5080692029ab80262a02c91
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadg...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com>
Gerrit-Reviewer: Martin Sivák <msi...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
