Mike Kolesnik has posted comments on this change. Change subject: engine: Add SP for retrieving templates by vnic profile ......................................................................
Patch Set 24: (1 inline comment) .................................................... File packaging/dbscripts/vm_templates_sp.sql Line 417: WHERE EXISTS ( Line 418: SELECT 1 Line 419: FROM vm_interface Line 420: INNER JOIN vnic_profiles Line 421: ON vnic_profiles.id = vm_interface.vnic_profile_id Why join? Seems redundant since you don't use it later... Line 422: WHERE vm_interface.vnic_profile_id = v_vnic_profile_id Line 423: AND vm_interface.vmt_guid = vm_templates_view.vmt_guid); Line 424: END; $procedure$ Line 425: LANGUAGE plpgsql; -- To view, visit http://gerrit.ovirt.org/16670 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If143d7c23235c5aa56b1cb1f94f003eae7fe20a3 Gerrit-PatchSet: 24 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Giuseppe Vallarelli <gvall...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
