Oved Ourfali has posted comments on this change.

Change subject: packaging: setup: support HA services
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File src/plugins/ovirt-hosted-engine-setup/engine/add_host.py
Line 120: 
Line 121:     def _wait_host_ready(self, engine_api, host):
Line 122:         self.logger.info(_(
Line 123:             'Waiting for VDSM host to become operational.'
Line 124:             'This may take several minutes...'
I'd write:
Waiting for the host to become operational in the engine

or something similar.
Line 125:         ))
Line 126:         tries = self.VDSM_RETRIES
Line 127:         isUp = False
Line 128:         while not isUp and tries > 0:


-- 
To view, visit http://gerrit.ovirt.org/17334
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9007d229da2fb8dec52361a011995a1de6c2db7f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com>
Gerrit-Reviewer: Lev Veyde <lve...@gmail.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to