Yair Zaslavsky has posted comments on this change.
Change subject: engine: Removed ValueObjects
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ObjectIdentityChecker.java
Line 183: for (PropertyInfo property : properties) {
Line 184: Object sourceValue = property.getValue(source, null);
Line 185: Object destinationValue =
property.getValue(destination, null);
Line 186:
Line 187: if (property.getCanWrite()
Shouldn't we check here if the proper is not istance of HashMap?
Line 188: && sourceValue != null &&
!sourceValue.equals(destinationValue)
Line 189: || ((sourceValue == null && destinationValue
!= null))) {
Line 190: returnValue.add(property.getName());
Line 191: }
--
To view, visit http://gerrit.ovirt.org/16820
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If803494f7c10646c106058bdbb77d104d7d106fc
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
