Liran Zelkha has posted comments on this change.
Change subject: engine : VdsUpdateRuntimeInfo updates the data of a specific
VDS.
......................................................................
Patch Set 12: (1 inline comment)
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDynamicDAODbFacadeImpl.java
Line 66: return DiskImageDynamicRowMapper.instance;
Line 67: }
Line 68:
Line 69: @Override
Line 70: public void updateAllInTransaction(Map<Guid, DiskImageDynamic>
vmDiskImageDynamicToSave) {
The name of the stored procedure and the mapper change between DAOs, so hard
wiring them in MassOperations is impossible.
Giving the caller the responsibility for building the mapper is a waste, since
it reduces reuse.
Putting some single, hard-coded, proc-name/mapper in the DAO itself is also not
good enough, since we need to start having separate procedures for updating
different data.
So - it was in MassOperations in the beginning - but I was forced to move it to
the DAO. Please recheck, or explain to me what you mean.
Line 71: updateAllInBatch("Updatedisk_image_dynamic",
Line 72: vmDiskImageDynamicToSave.values(),
Line 73: new MapSqlParameterMapper<DiskImageDynamic>() {
Line 74:
--
To view, visit http://gerrit.ovirt.org/16066
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3e9735f4174ebabbe293d397d931aba72bbbd7b
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liran Zelkha <liran.zel...@gmail.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Liran Zelkha <liran.zel...@gmail.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
