Shahar Havivi has posted comments on this change.
Change subject: Support for multiple heads for Qxl display device
......................................................................
Patch Set 9: (6 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
Line 387: }
Line 388: return legal;
Line 389: }
Line 390:
Line 391: public static boolean isSingleQxlDeviceLegal(DisplayType
displayType, int osId, List<String> reasons) {
Done
Line 392: if (displayType != DisplayType.qxl) {
Line 393:
reasons.add(VdcBllMessages.ACTION_TYPE_FAILED_ILLEGAL_SINGLE_DEVICE_DISPLAY_TYPE.toString());
Line 394: return false;
Line 395: }
Line 392: if (displayType != DisplayType.qxl) {
Line 393:
reasons.add(VdcBllMessages.ACTION_TYPE_FAILED_ILLEGAL_SINGLE_DEVICE_DISPLAY_TYPE.toString());
Line 394: return false;
Line 395: }
Line 396: if (!OsRepositoryImpl.INSTANCE.isLinux(osId)) {
I will check that
Line 397:
reasons.add(VdcBllMessages.ACTION_TYPE_FAILED_ILLEGAL_SINGLE_DEVICE_OS_TYPE.toString());
Line 398: return false;
Line 399: }
Line 400: return true;
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java
Line 58: @Override
Line 59: protected void buildVmVideoCards() {
Line 60: createInfo.put(VdsProperties.display,
vm.getDisplayType().toString());
Line 61: // the requested display type might be different than the
default display of
Line 62: // the VM in Run Once scenario, in that case we need to add
proper video device.
No,
There is no ability in run-once to select/change the number of monitors.
Line 63: if (vm.getDisplayType() != vm.getDefaultDisplayType()) {
Line 64: addVideoCardByDisplayType(vm.getDisplayType(),
vm.getNumOfMonitors());
Line 65: }
Line 66: else {
Line 63: if (vm.getDisplayType() != vm.getDefaultDisplayType()) {
Line 64: addVideoCardByDisplayType(vm.getDisplayType(),
vm.getNumOfMonitors());
Line 65: }
Line 66: else {
Line 67: addVideoCardsDefinedForVmInDB(vm.getId(),
vm.getSingleQxlPci());
will check...
Line 68: }
Line 69: }
Line 70:
Line 71: /**
....................................................
Commit Message
Line 3: AuthorDate: 2013-07-10 15:31:37 +0300
Line 4: Commit: Shahar Havivi <shav...@redhat.com>
Line 5: CommitDate: 2013-07-28 16:25:02 +0300
Line 6:
Line 7: Support for multiple heads for Qxl display device
Done
Line 8:
Line 9: Bug-Url: https://bugzilla.redhat.com/787578
Line 10: Change-Id: If18b8ceba3d641f3e2e79947b34b549902f00b55
....................................................
File packaging/dbscripts/create_tables.sql
Line 184: description VARCHAR(4000),
Line 185: vds_group_id UUID NOT NULL,
Line 186: domain VARCHAR(40),
Line 187: num_of_monitors INTEGER NOT NULL,
Line 188: single_qxl_pci BOOLEAN default false,
Done
Line 189: status INTEGER NOT NULL,
Line 190: usb_policy INTEGER,
Line 191: time_zone VARCHAR(40),
Line 192: is_auto_suspend BOOLEAN default false,
--
To view, visit http://gerrit.ovirt.org/16803
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If18b8ceba3d641f3e2e79947b34b549902f00b55
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shav...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
