Michael Pasternak has posted comments on this change.

Change subject: API: Adding mapping between host and action parameters and 
using username field
......................................................................


Patch Set 3: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File 
backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
Line 1856:           host.port: 'xs:int', host.storage_manager.priority: 
'xs:int', host.power_management.type: 'xs:string',
Line 1857:           host.power_management.enabled: 'xs:boolean', 
host.power_management.address: 'xs:string', host.power_management.username: 
'xs:string',
Line 1858:           host.power_management.password: 'xs:string', 
host.power_management.options.option--COLLECTION: {option.name: 'xs:string', 
option.value: 'xs:string'},  host.power_management.pm_proxy--COLLECTION: 
{propietary : 'xs:string'}, 
host.power_management.agents.agent--COLLECTION:{type: 'xs:string', address: 
'xs:string', user_name: 'xs:string', password: 'xs:string', 
options.option--COLLECTION: {option.name: 'xs:string', option.value: 
'xs:string'}}}
Line 1859: - mandatoryArguments: {}
Line 1860:         optionalArguments: {host.name: 'xs:string', host.comment: 
'xs:string', host.address: 'xs:string', host.ssh.password: 'xs:string', 
host.ssh.port: 'xs:int', host.ssh.fingerprint: 'xs:string', 
host.ssh.authentication_type: 'xs:string', host.display.address: 'xs:string', 
host.cluster.id|name: 'xs:string',
please fix formatting, otherwise, yaml won't load
Line 1861:           host.port: 'xs:int', host.storage_manager.priority: 
'xs:int', host.power_management.type: 'xs:string',
Line 1862:           host.power_management.enabled: 'xs:boolean', 
host.power_management.address: 'xs:string', host.power_management.username: 
'xs:string',
Line 1863:           host.power_management.password: 'xs:string', 
host.power_management.options.option--COLLECTION: {option.name: 'xs:string', 
option.value: 'xs:string'},  host.power_management.pm_proxy--COLLECTION: 
{propietary : 'xs:string'}, 
host.power_management.agents.agent--COLLECTION:{type: 'xs:string', address: 
'xs:string', user_name: 'xs:string', password: 'xs:string', 
options.option--COLLECTION: {option.name: 'xs:string', option.value: 
'xs:string'}}}
Line 1864:     urlparams:


-- 
To view, visit http://gerrit.ovirt.org/17194
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc7f6ba85ed6a5a790b3cc0acce3f5d6eb305789
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to