Liron Ar has posted comments on this change.
Change subject: core: Add storage validation when plugging an image.
......................................................................
Patch Set 4: (2 inline comments)
please return the save of the vm device.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java
Line 117
Line 118
Line 119
Line 120
Line 121
please return it, otherwise the attach won't work
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommand.java
Line 49: checkCanPerformPlugUnPlugDisk() &&
Line 50: isVmNotInPreviewSnapshot() &&
Line 51: imageValidation();
Line 52: }
Line 53:
please verify that we have unified behaviour here, meaning that the order of
the operations doesn't matter (when hotplugging a disk and changing domain
status) - seems to me like with current implementation we will have mixed
results.
Line 54: private boolean imageValidation() {
Line 55: if (disk.getDiskStorageType() != DiskStorageType.IMAGE) {
Line 56: return true;
Line 57: }
--
To view, visit http://gerrit.ovirt.org/17170
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieeb2522bc5aa280b9b98ef728737aeeaa82d1263
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
