ofri masad has uploaded a new change for review.
Change subject: core: Fix runUpdateMomPolicy in InitVdsOnUpCommand
......................................................................
core: Fix runUpdateMomPolicy in InitVdsOnUpCommand
The method used the wrong kind of return value.
Change-Id: I5fc671994013e7bd5ac5706316f2a64ba25c1015
Signed-off-by: Ofri Masad <oma...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java
1 file changed, 5 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/05/17405/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java
index 04c0cff..fc580d2 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java
@@ -246,17 +246,17 @@
return result;
}
- private EventResult runUpdateMomPolicy(final VDSGroup cluster, final VDS
vds) {
- EventResult result = new EventResult(true, EventType.VDSCONNECTTOPOOL);
+ private VDSReturnValue runUpdateMomPolicy(final VDSGroup cluster, final
VDS vds) {
+ VDSReturnValue returnValue = new VDSReturnValue();
try {
- runVdsCommand(VDSCommandType.SetMOMPolicyParameters,
+ returnValue = runVdsCommand(VDSCommandType.SetMOMPolicyParameters,
new MomPolicyVDSParameters(vds,
cluster.isEnableBallooning()));
} catch (VdcBLLException e) {
log.errorFormat("Could not update MoM policy on host {0}",
vds.getName());
- result.setSuccess(false);
+ returnValue.setSucceeded(false);
}
- return result;
+ return returnValue;
}
protected boolean proceedVdsStats() {
--
To view, visit http://gerrit.ovirt.org/17405
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5fc671994013e7bd5ac5706316f2a64ba25c1015
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <oma...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
