Yaniv Bronhaim has posted comments on this change. Change subject: engine: Adding no-arg constructor to gluster parameters ......................................................................
Patch Set 1: Verified; Looks good to me, but someone else must approve I don't fully understand why we need no-arg constructors for all those classes without any change in the usage. It shouldn't compile if we create those classes without matching constructor. Although, the patch does the work .. -- To view, visit http://gerrit.ovirt.org/17368 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ab197e9fb8f9d8f7f0be021716a6b3a028f1546 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
