Gilad Chaplik has posted comments on this change.
Change subject: webadmin,userportal: added singular form of nics assignment
message
......................................................................
Patch Set 1: Looks good to me, approved
(2 inline comments)
minor comment, please fix while rebasing.
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationMessages.java
Line 104:
Line 105: @DefaultMessage("default: {0}")
Line 106: String defaultTimeZoneCaption(String currentDefault);
Line 107:
Line 108: @DefaultMessage("VM has {0} Nics. Assign them to the Cluster''s
Logical network(s).")
cluster''s with double apostrophe?
Line 109: String assignNicsToNetworksPlural(int numOfNics);
Line 110:
Line 111: @DefaultMessage("VM has 1 Nic. Assign it to the Cluster''s
Logical network(s).")
Line 112: String assignNicsToNetworksSingular();
Line 107:
Line 108: @DefaultMessage("VM has {0} Nics. Assign them to the Cluster''s
Logical network(s).")
Line 109: String assignNicsToNetworksPlural(int numOfNics);
Line 110:
Line 111: @DefaultMessage("VM has 1 Nic. Assign it to the Cluster''s
Logical network(s).")
same.
Line 112: String assignNicsToNetworksSingular();
--
To view, visit http://gerrit.ovirt.org/17312
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I312f8b9fb4808edf90492461b69541038af30393
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
