Eli Mesika has uploaded a new change for review.

Change subject: core: External events' audit logs has not...
......................................................................

core: External events' audit logs has not...

External events' audit logs has not records in AuditLogMessages.properties

Adding missing messages to AuditLogMessages.properties
In addition this patch moves initialization of those messages to their own
method in AuditLogDirector

Change-Id: Ie06d4bd179b077013116f7f9776827532ce05cea
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=987830
Signed-off-by: Eli Mesika <emes...@redhat.com>
---
M 
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java
M 
backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
2 files changed, 7 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/74/17374/1

diff --git 
a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java
 
b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java
index 0f3d159..e16c04c 100644
--- 
a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java
+++ 
b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java
@@ -59,6 +59,7 @@
         initUserAccountSeverities();
         initCommonSeverities();
         initClusterPolicySeverities();
+        initExtrnalEvents();
     }
 
     private static void initProviderSeverities() {
@@ -761,7 +762,9 @@
         
severities.put(AuditLogType.VLAN_ID_MISMATCH_FOR_MANAGEMENT_NETWORK_CONFIGURATION,
 AuditLogSeverity.ERROR);
         
severities.put(AuditLogType.SETUP_NETWORK_FAILED_FOR_MANAGEMENT_NETWORK_CONFIGURATION,
 AuditLogSeverity.ERROR);
         
severities.put(AuditLogType.PERSIST_NETWORK_FAILED_FOR_MANAGEMENT_NETWORK, 
AuditLogSeverity.WARNING);
+    }
 
+    private static void initExtrnalEvents() {
         // External Events/Alerts
         severities.put(AuditLogType.EXTERNAL_EVENT_NORMAL, 
AuditLogSeverity.NORMAL);
         severities.put(AuditLogType.EXTERNAL_EVENT_WARNING, 
AuditLogSeverity.WARNING);
diff --git 
a/backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
 
b/backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
index 56349a0..ddfe945 100644
--- 
a/backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
+++ 
b/backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
@@ -662,3 +662,7 @@
 USER_FAILED_TO_UPDATE_CLUSTER_POLICY=Failed to update Clsuter Policy: 
${ClusterPolicy}. (User: ${UserName})
 USER_REMOVE_CLUSTER_POLICY=Clsuter Policy ${ClusterPolicy} was removed. (User: 
${UserName})
 USER_FAILED_TO_REMOVE_CLUSTER_POLICY=Failed to remove Clsuter Policy: 
${ClusterPolicy}. (User: ${UserName})
+EXTERNAL_EVENT_NORMAL=NORMAL external event has been added.
+EXTERNAL_EVENT_WARNING=WARNING external event has been added.
+EXTERNAL_EVENT_ERROR=ERROR external event has been added.
+EXTERNAL_ALERT=ALERT external event has been added.


-- 
To view, visit http://gerrit.ovirt.org/17374
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie06d4bd179b077013116f7f9776827532ce05cea
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to