Gilad Chaplik has posted comments on this change.

Change subject: webadmin: cluster policy look & feel enhancements
......................................................................


Patch Set 2: (2 inline comments)

....................................................
File 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/scheduling/panels/PolicyUnitListPanel.java
Line 30: 
Line 31:     private boolean doDrag(DragDropEventBase<?> event, boolean isDrop) 
{
Line 32:         String dragDropEventData = 
PolicyUnitPanel.getDragDropEventData(event, isDrop);
Line 33:         String[] split = dragDropEventData.split(" "); //$NON-NLS-1$
Line 34:         if (split != null && split.length == 3) {
Done
Line 35:             if (!type.equals(split[0])) {
Line 36:                 return false;
Line 37:             } else if (Boolean.valueOf(split[2]).equals(used)) {
Line 38:                 return false;


....................................................
File 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/scheduling/panels/PolicyUnitStyle.java
Line 2: 
Line 3: import com.google.gwt.resources.client.CssResource;
Line 4: 
Line 5: public interface PolicyUnitStyle extends CssResource {
Line 6:     String unusedPolicyUnitStyle();
Done
Line 7: 
Line 8:     String usedFilterPolicyUnitStyle();
Line 9: 
Line 10:     String positionLabelStyle();


-- 
To view, visit http://gerrit.ovirt.org/17371
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie321547211217e837c8fe7b57866ef741d4a29e0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to