Allon Mureinik has posted comments on this change.
Change subject: core: Fix GWT RPC serialization issue in RepoImage
......................................................................
Patch Set 1: Looks good to me, approved
(1 inline comment)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/RepoImage.java
Line 27: */
Line 28: public RepoImage() {
Line 29: storagePoolId = Guid.Empty;
Line 30: repoDomainId = Guid.Empty;
Line 31: size = 0;
This is probably redundant, as longs by default initialize to 0.
If you want to keep it, might as well initialize it with a long literal (0L)
and not an int literal.
Line 32: dateCreated = new Date();
Line 33: }
Line 34:
Line 35: /**
--
To view, visit http://gerrit.ovirt.org/17352
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7085762877afc8f76090cf18f38bd303c5db2864
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
