Vojtech Szocs has posted comments on this change.

Change subject: backend: ExportRepoImageParameters default constructor
......................................................................


Patch Set 1: Looks good to me, but someone else must approve

(1 inline comment)

> This is another instance of the GWT RPC issues that we are suffering.

If I'm not mistaken, the problem here is missing no-arg constructor. Any object 
participating in GWT RPC should have no-arg constructor, in addition to any 
other constructors.

....................................................
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ExportRepoImageParameters.java
Line 7:     private static final long serialVersionUID = 8168949491104775480L;
Line 8: 
Line 9:     private Guid destinationDomainId;
Line 10: 
Line 11:     @SuppressWarnings("unused")
I think @SuppressWarnings("unused") is not necessary since the no-arg 
constructor is public.
Line 12:     public ExportRepoImageParameters() {
Line 13:         super();
Line 14:     }
Line 15: 


-- 
To view, visit http://gerrit.ovirt.org/17342
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I63556883c8d81ce3914feac5a76d102d3964c678
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to