Shubhendu Tripathi has posted comments on this change.
Change subject: engine: Introduce VnicProfileCommon class
......................................................................
Patch Set 20: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/VnicProfileCommon.java
Line 10: import
org.ovirt.engine.core.common.businessentities.network.VnicProfile;
Line 11: import org.ovirt.engine.core.common.errors.VdcBllMessages;
Line 12: import org.ovirt.engine.core.compat.Guid;
Line 13:
Line 14: public abstract class VnicProfileCommon<T extends
VnicProfileParameters> extends CommandBase<T> {
You may want to rename this class to something like "VnicProfileCommandBase"
Line 15: public VnicProfileCommon(T parameters) {
Line 16: super(parameters);
Line 17: }
Line 18:
--
To view, visit http://gerrit.ovirt.org/16673
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I71debdb5fe5dc42b308ccd8bd3e177191f9d2a3a
Gerrit-PatchSet: 20
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
