Shubhendu Tripathi has posted comments on this change. Change subject: engine: Add AddVnicProfileCommand ......................................................................
Patch Set 20: (3 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AddVnicProfileCommand.java Line 24: getVnicProfileDao().save(getVnicProfile()); Line 25: NetworkHelper.addPermissionsOnVnicProfile(getCurrentUser().getUserId(), Line 26: getVnicProfile().getId(), Line 27: getParameters().isPublicUse()); Line 28: getReturnValue().setActionReturnValue(getVnicProfile().getId()); Is it ok to set succeeded to true without checking return value for errors? Line 29: setSucceeded(true); Line 30: } Line 31: Line 32: @Override .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java Line 85: CommitNetworkChanges(157, ActionGroup.CONFIGURE_HOST_NETWORK, QuotaDependency.NONE), Line 86: SetupNetworks(158, ActionGroup.CONFIGURE_HOST_NETWORK, QuotaDependency.NONE), Line 87: Line 88: // VnicProfile Commands Line 89: AddVnicProfile(160, ActionGroup.CREATE_NETWORK_VNIC_PROFILE, false, QuotaDependency.NONE), Shouldn't the value of first parameter be 159 here? Line 90: Line 91: // VmTemplatesCommand Line 92: AddVmTemplate(201, ActionGroup.CREATE_TEMPLATE, QuotaDependency.BOTH), Line 93: UpdateVmTemplate(202, ActionGroup.EDIT_TEMPLATE_PROPERTIES, QuotaDependency.VDS_GROUP), .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java Line 580: INVALID_INTERFACE_FOR_MANAGEMENT_NETWORK_CONFIGURATION(1118), Line 581: VLAN_ID_MISMATCH_FOR_MANAGEMENT_NETWORK_CONFIGURATION(1119), Line 582: SETUP_NETWORK_FAILED_FOR_MANAGEMENT_NETWORK_CONFIGURATION(1120), Line 583: PERSIST_NETWORK_FAILED_FOR_MANAGEMENT_NETWORK(1121), Line 584: ADD_VNIC_PROFILE(1121), Repeated value 1121 Line 585: ADD_VNIC_PROFILE_FAILED(1122), Line 586: Line 587: // Import/Export Line 588: IMPORTEXPORT_STARTING_EXPORT_VM(1162), -- To view, visit http://gerrit.ovirt.org/16674 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27100ced5acfdf9cc1125f865937fd0d7e4ffd17 Gerrit-PatchSet: 20 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
